Messages in this thread | | | Subject | Re: [PATCH v2 -next] thermal: power_allocator: Fix Kconfig warning | From | Daniel Lezcano <> | Date | Wed, 4 Dec 2019 16:49:53 +0100 |
| |
On 13/11/2019 11:53, YueHaibing wrote: > When do randbuiding, we got this: > > WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR > Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n] > Selected by [y]: > - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice> > > Make THERMAL_DEFAULT_GOV_POWER_ALLOCATOR depend on > THERMAL_DEFAULT_GOV_POWER_ALLOCATOR to fix this warning. > > Suggested-by: Quentin Perret <qperret@google.com> > Fixes: a4e893e802e6 ("thermal: cpu_cooling: Migrate to using the EM framework") > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied with a slight message clarification.
Thanks for the fix.
> --- > drivers/thermal/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 59b79fc..79b2786 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -108,7 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE > > config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR > bool "power_allocator" > - select THERMAL_GOV_POWER_ALLOCATOR > + depends on THERMAL_GOV_POWER_ALLOCATOR > help > Select this if you want to control temperature based on > system and device power allocation. This governor can only >
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |