lkml.org 
[lkml]   [2019]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 067/209] net/mlx5: Continue driver initialization despite debugfs failure
    Date
    From: Leon Romanovsky <leonro@mellanox.com>

    [ Upstream commit 199fa087dc6b503baad06712716fac645a983e8a ]

    The failure to create debugfs entry is unpleasant event, but not enough
    to abort drier initialization. Align the mlx5_core code to debugfs design
    and continue execution whenever debugfs_create_dir() successes or not.

    Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters")
    Reviewed-by: Saeed Mahameed <saeedm@mellanox.com>
    Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
    Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/main.c | 8 +++-----
    1 file changed, 3 insertions(+), 5 deletions(-)

    diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
    index 97874c2568fc9..1ac0e173da12c 100644
    --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
    @@ -838,11 +838,9 @@ static int mlx5_pci_init(struct mlx5_core_dev *dev, struct mlx5_priv *priv)

    priv->numa_node = dev_to_node(&dev->pdev->dev);

    - priv->dbg_root = debugfs_create_dir(dev_name(&pdev->dev), mlx5_debugfs_root);
    - if (!priv->dbg_root) {
    - dev_err(&pdev->dev, "Cannot create debugfs dir, aborting\n");
    - return -ENOMEM;
    - }
    + if (mlx5_debugfs_root)
    + priv->dbg_root =
    + debugfs_create_dir(pci_name(pdev), mlx5_debugfs_root);

    err = mlx5_pci_enable_device(dev);
    if (err) {
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-04 19:24    [W:4.183 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site