Messages in this thread | | | Subject | Re: [PATCH] stmmac: debugfs entry name is not be changed when udev rename device name. | From | Jiping Ma <> | Date | Tue, 31 Dec 2019 10:28:56 +0800 |
| |
On 12/31/2019 10:22 AM, Randy Dunlap wrote: > On 12/30/19 6:16 PM, Jiping Ma wrote: >> >> On 12/31/2019 10:11 AM, Randy Dunlap wrote: >>> Hi, >>> >>> On 12/30/19 6:03 PM, Jiping Ma wrote: >>>> Add one notifier for udev changes net device name. >>>> >>>> Signed-off-by: Jiping Ma <jiping.ma2@windriver.com> >>>> --- >>>> .../net/ethernet/stmicro/stmmac/stmmac_main.c | 38 ++++++++++++++++++- >>>> 1 file changed, 37 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >>>> index b14f46a57154..c1c877bb4421 100644 >>>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >>>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >>>> @@ -4038,6 +4038,40 @@ static int stmmac_dma_cap_show(struct seq_file *seq, void *v) >>>> } >>>> DEFINE_SHOW_ATTRIBUTE(stmmac_dma_cap); >>>> +/** >>> Just use /* here since this is not a kernel-doc comment. >>> /** is reserved for kernel-doc comments/notation. >> I use checkpatch.pl to check my patch, it show one warning, then I change * to **. I will change it back to *. > It should be more like: > > /* Use network device events to create/remove/rename > * debugfs file entries. > */ > Got it. Thanks. >> WARNING: networking block comments don't use an empty /* line, use /* Comment... >> #23: FILE: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4042: >> +/* >> + * Use network device events to create/remove/rename >>>> + * Use network device events to create/remove/rename >>>> + * debugfs file entries >>>> + */ >>>> +static int stmmac_device_event(struct notifier_block *unused, >>>> + unsigned long event, void *ptr) >>>> +{ >
| |