lkml.org 
[lkml]   [2019]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 100/321] ubi: Put MTD device after it is not used
    Date
    From: Pan Bian <bianpan2016@163.com>

    [ Upstream commit b95f83ab762dd6211351b9140f99f43644076ca8 ]

    The MTD device reference is dropped via put_mtd_device, however its
    field ->index is read and passed to ubi_msg. To fix this, the patch
    moves the reference dropping after calling ubi_msg.

    Signed-off-by: Pan Bian <bianpan2016@163.com>
    Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
    Signed-off-by: Richard Weinberger <richard@nod.at>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/ubi/build.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
    index d2a726654ff11..c120c8761fcd2 100644
    --- a/drivers/mtd/ubi/build.c
    +++ b/drivers/mtd/ubi/build.c
    @@ -1101,10 +1101,10 @@ int ubi_detach_mtd_dev(int ubi_num, int anyway)
    ubi_wl_close(ubi);
    ubi_free_internal_volumes(ubi);
    vfree(ubi->vtbl);
    - put_mtd_device(ubi->mtd);
    vfree(ubi->peb_buf);
    vfree(ubi->fm_buf);
    ubi_msg(ubi, "mtd%d is detached", ubi->mtd->index);
    + put_mtd_device(ubi->mtd);
    put_device(&ubi->dev);
    return 0;
    }
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-03 23:50    [W:7.118 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site