Messages in this thread | | | Date | Tue, 3 Dec 2019 14:32:03 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] sound: codecs: gtm601: add Broadmobi bm818 sound profile |
| |
On Mon, Dec 02, 2019 at 10:48:30AM -0700, Angus Ainslie (Purism) wrote:
> + if (np && of_device_is_compatible(np, "broadmobi,bm818")) > + dai_driver = &bm818_dai;
Rather than having a tree of these it'd be better if...
> #if defined(CONFIG_OF) > static const struct of_device_id gtm601_codec_of_match[] = { > { .compatible = "option,gtm601", }, > + { .compatible = "broadmobi,bm818", }, > {}, > };
...this used the data you can provide along with the of_match as the dai_driver so the probe function doesn't have to know about the individual variants. [unhandled content-type:application/pgp-signature] | |