lkml.org 
[lkml]   [2019]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/3] dt-bindings: ipmi: aspeed: Introduce a v2 binding for KCS
On Tue, Dec 3, 2019 at 6:36 AM Andrew Jeffery <andrew@aj.id.au> wrote:
>
> The v2 binding utilises reg and renames some of the v1 properties.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt | 20 +++++---
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt
> index d98a9bf45d6c..76b180ebbde4 100644
> --- a/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt
> +++ b/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt
> @@ -1,9 +1,10 @@
> -* Aspeed KCS (Keyboard Controller Style) IPMI interface
> +# Aspeed KCS (Keyboard Controller Style) IPMI interface
>
> The Aspeed SOCs (AST2400 and AST2500) are commonly used as BMCs
> (Baseboard Management Controllers) and the KCS interface can be
> used to perform in-band IPMI communication with their host.
>
> +## v1
> Required properties:
> - compatible : should be one of
> "aspeed,ast2400-kcs-bmc"
> @@ -12,14 +13,21 @@ Required properties:
> - kcs_chan : The LPC channel number in the controller
> - kcs_addr : The host CPU IO map address
>
> +## v2
> +Required properties:
> +- compatible : should be one of
> + "aspeed,ast2400-kcs-bmc-v2"
> + "aspeed,ast2500-kcs-bmc-v2"
> +- reg : The address and size of the IDR, ODR and STR registers
> +- interrupts : interrupt generated by the controller
> +- slave-reg : The host CPU IO map address

aspeed,slave-reg

>
> Example:
>
> - kcs3: kcs3@0 {
> - compatible = "aspeed,ast2500-kcs-bmc";
> - reg = <0x0 0x80>;
> + kcs3: kcs@24 {
> + compatible = "aspeed,ast2500-kcs-bmc-v2";
> + reg = <0x24 0x1>, <0x30 0x1>, <0x3c 0x1>;

What are the other registers in this address space? I'm not so sure
this is an improvement if you end up with a bunch of nodes with single
registers.

> interrupts = <8>;
> - kcs_chan = <3>;
> - kcs_addr = <0xCA2>;
> + slave-reg = <0xca2>;
> status = "okay";
> };
> --
> git-series 0.9.1

\
 
 \ /
  Last update: 2019-12-03 15:32    [W:0.087 / U:12.936 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site