lkml.org 
[lkml]   [2019]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] ARM: dts: at91: Reenable UART TX pull-ups
Date
On 2019-11-28 11:06, Ingo van Lil wrote:
> Pull-ups for SAM9 UART/USART TX lines were disabled in 5e04822f.
> However, several chips in the SAM9 family require pull-ups to prevent
> the TX lines from falling (and causing an endless break condition) when
> the transceiver is disabled.
>
> From the SAM9G20 datasheet, 32.5.1: "To prevent the TXD line from
> falling when the USART is disabled, the use of an internal pull up
> is mandatory.". This commit reenables the pull-ups for all chips having
> that sentence in their datasheets.
>
> Signed-off-by: Ingo van Lil <inguin@gmx.de>

Sounds reasonable, and sorry for the breakage. However, perhaps a proper
fixes tag (with the prescribed length of the commit hash) should be in
there somewhere?

Fixes: 5e04822f7db5 ("ARM: dts: at91: fixes uart pinctrl, set pullup on rx, clear pullup on tx")

Also, I think the same kind of change was made to the barebox bootloader
at about the same time. Is there a fix for that queued up as well?

Cheers,
Peter
\
 
 \ /
  Last update: 2019-12-03 14:05    [W:0.036 / U:4.792 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site