lkml.org 
[lkml]   [2019]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subjectfsl,p2020-esdhc sdhci quirks
Date
Hi

Commits

05cb6b2a66fa - mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358
support
a46e42712596 - mmc: sdhci-of-esdhc: add erratum eSDHC5 support

seem a bit odd, in that they set bits from the SDHCI_* namespace in the
->quirks2 member:

host->quirks2 |= SDHCI_QUIRK_RESET_AFTER_REQUEST;
host->quirks2 |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;

These are bits 10 and 12, so they are also known as
SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD and
SDHCI_QUIRK2_TUNING_WORK_AROUND. So if the fixes are correct, one should
use those names on the right-hand side, but it seems just as likely (I
can't figure that out from the commit messages) that the left-hand sides
should have been host->quirks ?

Rasmus

\
 
 \ /
  Last update: 2019-12-03 11:16    [W:0.029 / U:3.040 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site