lkml.org 
[lkml]   [2019]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] x86_64_defconfig: Normalize x86_64 defconfig
From
Date
Hi Krzysztof,

Many thanks for your quick answer.

On 3/12/19 3:15, Krzysztof Kozlowski wrote:
> On Tue, 3 Dec 2019 at 05:18, Enric Balletbo i Serra
> <enric.balletbo@collabora.com> wrote:
>>
>> make savedefconfig result in some difference, lets normalize the
>> defconfig
>>
>
> No, for two reasons:
> 1. If running savedefconfig at all, split reordering items from
> removal of non needed options. This way we can see exactly what is
> being removed. This patch moves things around so it is not possible to
> understand what exactly you're doing here...

Ok, makes sense, I can do it, but if you don't really care of having the
defconfig sync with the savedefconfig output for the below reasons or others,
that's fine with me.

The reason I send the patch is because I think that, at least on some arm
defconfigs, they try to have the defconfig sync with the savedefconfig output,
the idea is to try to make patching the file easier, but I know this is usually
a pain.

> 2. Do not remove options just because other select them in a blind way
> - via savedefconfig. As it turns out, some developers have different
> view on dependencies and they expect that defconfig *explicitly* pulls
> out necessary functions. IOW, they can safely remove any visible
> symbol dependency assuming that defconfigs are selecting this removed
> symbol explicitly. See:
> https://patchwork.kernel.org/patch/11260361/
> (commit which removed DEBUG_FS - Marek Szyprowski will bring it back,
> I think, and Steven Rostedt answer)
>

Also makes sense, and I didn't know this. My purpose is only add support for the
options missing for Chromebooks. If patch 2 alone is fine and enough for that
purpose, that works for me, and I can just drop this patch from the series. I
only tried to do the right thing to add new options.

Thanks,
Enric

> Best regards,
> Krzysztof
>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> ---
>>
>> arch/x86/configs/x86_64_defconfig | 90 +++++++++++--------------------
>> 1 file changed, 30 insertions(+), 60 deletions(-)
>>
>

\
 
 \ /
  Last update: 2019-12-03 10:06    [W:0.034 / U:15.280 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site