lkml.org 
[lkml]   [2019]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 004/321] ASoC: compress: fix unsigned integer overflow check
    Date
    From: Xiaojun Sang <xsang@codeaurora.org>

    [ Upstream commit d3645b055399538415586ebaacaedebc1e5899b0 ]

    Parameter fragments and fragment_size are type of u32. U32_MAX is
    the correct check.

    Signed-off-by: Xiaojun Sang <xsang@codeaurora.org>
    Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    Acked-by: Vinod Koul <vkoul@kernel.org>
    Link: https://lore.kernel.org/r/20191021095432.5639-1-srinivas.kandagatla@linaro.org
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/core/compress_offload.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
    index 516ec35873256..509038d6bccdb 100644
    --- a/sound/core/compress_offload.c
    +++ b/sound/core/compress_offload.c
    @@ -529,7 +529,7 @@ static int snd_compress_check_input(struct snd_compr_params *params)
    {
    /* first let's check the buffer parameter's */
    if (params->buffer.fragment_size == 0 ||
    - params->buffer.fragments > INT_MAX / params->buffer.fragment_size ||
    + params->buffer.fragments > U32_MAX / params->buffer.fragment_size ||
    params->buffer.fragments == 0)
    return -EINVAL;

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-04 00:08    [W:3.122 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site