lkml.org 
[lkml]   [2019]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 158/321] RDMA/srp: Propagate ib_post_send() failures to the SCSI mid-layer
    Date
    From: Bart Van Assche <bvanassche@acm.org>

    [ Upstream commit 2ee00f6a98c36f7e4ba07cc33f24cc5a69060cc9 ]

    This patch avoids that the SCSI mid-layer keeps retrying forever if
    ib_post_send() fails. This was discovered while testing immediate
    data support and passing a too large num_sge value to ib_post_send().

    Cc: Sergey Gorenko <sergeygo@mellanox.com>
    Cc: Max Gurtovoy <maxg@mellanox.com>
    Cc: Laurence Oberman <loberman@redhat.com>
    Signed-off-by: Bart Van Assche <bvanassche@acm.org>
    Signed-off-by: Doug Ledford <dledford@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/ulp/srp/ib_srp.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
    index bc6a44a16445c..03ee53adaacd2 100644
    --- a/drivers/infiniband/ulp/srp/ib_srp.c
    +++ b/drivers/infiniband/ulp/srp/ib_srp.c
    @@ -2357,6 +2357,7 @@ static int srp_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *scmnd)

    if (srp_post_send(ch, iu, len)) {
    shost_printk(KERN_ERR, target->scsi_host, PFX "Send failed\n");
    + scmnd->result = DID_ERROR << 16;
    goto err_unmap;
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-03 23:53    [W:2.428 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site