lkml.org 
[lkml]   [2019]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 125/161] spi: st-ssc4: add missed pm_runtime_disable
    Date
    From: Chuhong Yuan <hslester96@gmail.com>

    [ Upstream commit cd050abeba2a95fe5374eec28ad2244617bcbab6 ]

    The driver forgets to call pm_runtime_disable in probe failure
    and remove.
    Add the missed calls to fix it.

    Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
    Link: https://lore.kernel.org/r/20191118024848.21645-1-hslester96@gmail.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-st-ssc4.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/spi/spi-st-ssc4.c b/drivers/spi/spi-st-ssc4.c
    index a4e43fc19ece..5df01ffdef46 100644
    --- a/drivers/spi/spi-st-ssc4.c
    +++ b/drivers/spi/spi-st-ssc4.c
    @@ -385,6 +385,7 @@ static int spi_st_probe(struct platform_device *pdev)
    return 0;

    clk_disable:
    + pm_runtime_disable(&pdev->dev);
    clk_disable_unprepare(spi_st->clk);
    put_master:
    spi_master_put(master);
    @@ -396,6 +397,8 @@ static int spi_st_remove(struct platform_device *pdev)
    struct spi_master *master = platform_get_drvdata(pdev);
    struct spi_st *spi_st = spi_master_get_devdata(master);

    + pm_runtime_disable(&pdev->dev);
    +
    clk_disable_unprepare(spi_st->clk);

    pinctrl_pm_select_sleep_state(&pdev->dev);
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-29 19:14    [W:4.059 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site