lkml.org 
[lkml]   [2019]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 198/434] ACPI: button: Add DMI quirk for Medion Akoya E2215T
    Date
    From: Hans de Goede <hdegoede@redhat.com>

    [ Upstream commit 932e1ba486117de2fcea3df27ad8218ad6c11470 ]

    The Medion Akoya E2215T's ACPI _LID implementation is quite broken:

    1. For notifications it uses an ActiveLow Edge GpioInt, rather then
    an ActiveBoth one, meaning that the device is only notified when the
    lid is closed, not when it is opened.

    2. Matching with this its _LID method simply always returns 0 (closed)

    In order for the Linux LID code to work properly with this implementation,
    the lid_init_state selection needs to be set to ACPI_BUTTON_LID_INIT_OPEN.

    This commit adds a DMI quirk for this.

    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/acpi/button.c | 11 +++++++++++
    1 file changed, 11 insertions(+)

    diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
    index 4a2cde2c536a..ce93a355bd1c 100644
    --- a/drivers/acpi/button.c
    +++ b/drivers/acpi/button.c
    @@ -78,6 +78,17 @@ static const struct dmi_system_id lid_blacklst[] = {
    DMI_MATCH(DMI_BIOS_VERSION, "BYT70A.YNCHENG.WIN.007"),
    },
    },
    + {
    + /*
    + * Medion Akoya E2215T, notification of the LID device only
    + * happens on close, not on open and _LID always returns closed.
    + */
    + .matches = {
    + DMI_MATCH(DMI_SYS_VENDOR, "MEDION"),
    + DMI_MATCH(DMI_PRODUCT_NAME, "E2215T MD60198"),
    + },
    + .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
    + },
    {}
    };

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-29 19:07    [W:4.232 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site