lkml.org 
[lkml]   [2019]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 240/434] RDMA/core: Fix return code when modify_port isnt supported
    Date
    From: Kamal Heib <kamalheib1@gmail.com>

    [ Upstream commit 55bfe905fa97633438c13fb029aed85371d85480 ]

    Improve return code from ib_modify_port() by doing the following:
    - Use "-EOPNOTSUPP" instead "-ENOSYS" which is the proper return code

    - Allow only fake IB_PORT_CM_SUP manipulation for RoCE providers that
    didn't implement the modify_port callback, otherwise return
    "-EOPNOTSUPP"

    Fixes: 61e0962d5221 ("IB: Avoid ib_modify_port() failure for RoCE devices")
    Link: https://lore.kernel.org/r/20191028155931.1114-2-kamalheib1@gmail.com
    Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
    Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/core/device.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
    index e6327d8f5b79..2b5bd7206fc6 100644
    --- a/drivers/infiniband/core/device.c
    +++ b/drivers/infiniband/core/device.c
    @@ -2409,8 +2409,12 @@ int ib_modify_port(struct ib_device *device,
    rc = device->ops.modify_port(device, port_num,
    port_modify_mask,
    port_modify);
    + else if (rdma_protocol_roce(device, port_num) &&
    + ((port_modify->set_port_cap_mask & ~IB_PORT_CM_SUP) == 0 ||
    + (port_modify->clr_port_cap_mask & ~IB_PORT_CM_SUP) == 0))
    + rc = 0;
    else
    - rc = rdma_protocol_roce(device, port_num) ? 0 : -ENOSYS;
    + rc = -EOPNOTSUPP;
    return rc;
    }
    EXPORT_SYMBOL(ib_modify_port);
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-29 19:05    [W:3.455 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site