lkml.org 
[lkml]   [2019]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 280/434] media: si470x-i2c: add missed operations in remove
    Date
    From: Chuhong Yuan <hslester96@gmail.com>

    [ Upstream commit 2df200ab234a86836a8879a05a8007d6b884eb14 ]

    The driver misses calling v4l2_ctrl_handler_free and
    v4l2_device_unregister in remove like what is done in probe failure.
    Add the calls to fix it.

    Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/radio/si470x/radio-si470x-i2c.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c b/drivers/media/radio/si470x/radio-si470x-i2c.c
    index 7541698a0be1..f491420d7b53 100644
    --- a/drivers/media/radio/si470x/radio-si470x-i2c.c
    +++ b/drivers/media/radio/si470x/radio-si470x-i2c.c
    @@ -482,6 +482,8 @@ static int si470x_i2c_remove(struct i2c_client *client)
    if (radio->gpio_reset)
    gpiod_set_value(radio->gpio_reset, 0);

    + v4l2_ctrl_handler_free(&radio->hdl);
    + v4l2_device_unregister(&radio->v4l2_dev);
    return 0;
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-29 19:03    [W:4.565 / U:0.892 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site