lkml.org 
[lkml]   [2019]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 295/434] net: ethernet: ti: Add dependency for TI_DAVINCI_EMAC
    Date
    From: Mao Wenan <maowenan@huawei.com>

    [ Upstream commit b2ef81dcdf3835bd55e5f97ff30131bb327be7fa ]

    If TI_DAVINCI_EMAC=y and GENERIC_ALLOCATOR is not set,
    below erros can be seen:
    drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_desc_pool_destroy.isra.14':
    davinci_cpdma.c:(.text+0x359): undefined reference to `gen_pool_size'
    davinci_cpdma.c:(.text+0x365): undefined reference to `gen_pool_avail'
    davinci_cpdma.c:(.text+0x373): undefined reference to `gen_pool_avail'
    davinci_cpdma.c:(.text+0x37f): undefined reference to `gen_pool_size'
    drivers/net/ethernet/ti/davinci_cpdma.o: In function `__cpdma_chan_free':
    davinci_cpdma.c:(.text+0x4a2): undefined reference to `gen_pool_free_owner'
    drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_chan_submit_si':
    davinci_cpdma.c:(.text+0x66c): undefined reference to `gen_pool_alloc_algo_owner'
    davinci_cpdma.c:(.text+0x805): undefined reference to `gen_pool_free_owner'
    drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_ctlr_create':
    davinci_cpdma.c:(.text+0xabd): undefined reference to `devm_gen_pool_create'
    davinci_cpdma.c:(.text+0xb79): undefined reference to `gen_pool_add_owner'
    drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_check_free_tx_desc':
    davinci_cpdma.c:(.text+0x16c6): undefined reference to `gen_pool_avail'

    This patch mades TI_DAVINCI_EMAC select GENERIC_ALLOCATOR.

    Fixes: 99f629718272 ("net: ethernet: ti: cpsw: drop TI_DAVINCI_CPDMA config option")
    Signed-off-by: Mao Wenan <maowenan@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/ti/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
    index 834afca3a019..137632b09c72 100644
    --- a/drivers/net/ethernet/ti/Kconfig
    +++ b/drivers/net/ethernet/ti/Kconfig
    @@ -22,6 +22,7 @@ config TI_DAVINCI_EMAC
    depends on ARM && ( ARCH_DAVINCI || ARCH_OMAP3 ) || COMPILE_TEST
    select TI_DAVINCI_MDIO
    select PHYLIB
    + select GENERIC_ALLOCATOR
    ---help---
    This driver supports TI's DaVinci Ethernet .

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-29 19:03    [W:2.500 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site