lkml.org 
[lkml]   [2019]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 179/434] media: st-mipid02: add a check for devm_gpiod_get_optional
    Date
    From: Chuhong Yuan <hslester96@gmail.com>

    [ Upstream commit 61c03b631b74a38ab53753f3ee971a55886d4843 ]

    mipid02_probe misses a check for devm_gpiod_get_optional and may miss
    the failure.
    Add a check to fix the problem.

    Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
    Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/i2c/st-mipid02.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c
    index 81285b8d5cfb..003ba22334cd 100644
    --- a/drivers/media/i2c/st-mipid02.c
    +++ b/drivers/media/i2c/st-mipid02.c
    @@ -971,6 +971,11 @@ static int mipid02_probe(struct i2c_client *client)
    bridge->reset_gpio = devm_gpiod_get_optional(dev, "reset",
    GPIOD_OUT_HIGH);

    + if (IS_ERR(bridge->reset_gpio)) {
    + dev_err(dev, "failed to get reset GPIO\n");
    + return PTR_ERR(bridge->reset_gpio);
    + }
    +
    ret = mipid02_get_regulators(bridge);
    if (ret) {
    dev_err(dev, "failed to get regulators %d", ret);
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-29 18:49    [W:3.227 / U:0.948 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site