lkml.org 
[lkml]   [2019]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 102/434] crypto: aegis128-neon - use Clang compatible cflags for ARM
    Date
    From: Ard Biesheuvel <ard.biesheuvel@linaro.org>

    [ Upstream commit 2eb2d198bd6cd0083a5363ce66272fb34a19928f ]

    The next version of Clang will start policing compiler command line
    options, and will reject combinations of -march and -mfpu that it
    thinks are incompatible.

    This results in errors like

    clang-10: warning: ignoring extension 'crypto' because the 'armv7-a'
    architecture does not support it [-Winvalid-command-line-argument]
    /tmp/aegis128-neon-inner-5ee428.s: Assembler messages:
    /tmp/aegis128-neon-inner-5ee428.s:73: Error: selected
    processor does not support `aese.8 q2,q14' in ARM mode

    when buiding the SIMD aegis128 code for 32-bit ARM, given that the
    'armv7-a' -march argument is considered to be compatible with the
    ARM crypto extensions. Instead, we should use armv8-a, which does
    allow the crypto extensions to be enabled.

    Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    crypto/Makefile | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/crypto/Makefile b/crypto/Makefile
    index fcb1ee679782..aa740c8492b9 100644
    --- a/crypto/Makefile
    +++ b/crypto/Makefile
    @@ -93,7 +93,7 @@ obj-$(CONFIG_CRYPTO_AEGIS128) += aegis128.o
    aegis128-y := aegis128-core.o

    ifeq ($(ARCH),arm)
    -CFLAGS_aegis128-neon-inner.o += -ffreestanding -march=armv7-a -mfloat-abi=softfp
    +CFLAGS_aegis128-neon-inner.o += -ffreestanding -march=armv8-a -mfloat-abi=softfp
    CFLAGS_aegis128-neon-inner.o += -mfpu=crypto-neon-fp-armv8
    aegis128-$(CONFIG_CRYPTO_AEGIS128_SIMD) += aegis128-neon.o aegis128-neon-inner.o
    endif
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-12-29 18:46    [W:5.934 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site