lkml.org 
[lkml]   [2019]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 03/17] soundwire: rename drv_to_sdw_slave_driver macro
On 17-12-19, 15:03, Pierre-Louis Bossart wrote:
> Align with previous renames and shorten macro
>
> No functionality change
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> drivers/soundwire/bus_type.c | 9 ++++-----
> include/linux/soundwire/sdw_type.h | 3 ++-
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c
> index c0585bcc8a41..2b2830b622fa 100644
> --- a/drivers/soundwire/bus_type.c
> +++ b/drivers/soundwire/bus_type.c
> @@ -34,7 +34,7 @@ sdw_get_device_id(struct sdw_slave *slave, struct sdw_driver *drv)
> static int sdw_bus_match(struct device *dev, struct device_driver *ddrv)
> {
> struct sdw_slave *slave = to_sdw_slave_device(dev);
> - struct sdw_driver *drv = drv_to_sdw_slave_driver(ddrv);
> + struct sdw_driver *drv = to_sdw_slave_driver(ddrv);

so patch 1 does:

- struct sdw_driver *drv = drv_to_sdw_driver(dev->driver);
+ struct sdw_driver *drv = drv_to_sdw_slave_driver(dev->driver);

and here we move drv_to_sdw_slave_driver to to_sdw_slave_driver... why
not do this in first patch and save step1... or did i miss something??

--
~Vinod

\
 
 \ /
  Last update: 2019-12-27 08:00    [W:0.143 / U:1.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site