lkml.org 
[lkml]   [2019]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 101/187] bnxt: apply computed clamp value for coalece parameter
    Date
    From: Jonathan Lemon <jonathan.lemon@gmail.com>

    [ Upstream commit 6adc4601c2a1ac87b4ab8ed0cb55db6efd0264e8 ]

    After executing "ethtool -C eth0 rx-usecs-irq 0", the box becomes
    unresponsive, likely due to interrupt livelock. It appears that
    a minimum clamp value for the irq timer is computed, but is never
    applied.

    Fix by applying the corrected clamp value.

    Fixes: 74706afa712d ("bnxt_en: Update interrupt coalescing logic.")
    Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
    Signed-off-by: Michael Chan <michael.chan@broadcom.com>
    Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    index 04ec909e06df..d31637da2537 100644
    --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
    @@ -6170,7 +6170,7 @@ static void bnxt_hwrm_set_coal_params(struct bnxt *bp,
    tmr = bnxt_usec_to_coal_tmr(bp, hw_coal->coal_ticks_irq);
    val = clamp_t(u16, tmr, 1,
    coal_cap->cmpl_aggr_dma_tmr_during_int_max);
    - req->cmpl_aggr_dma_tmr_during_int = cpu_to_le16(tmr);
    + req->cmpl_aggr_dma_tmr_during_int = cpu_to_le16(val);
    req->enables |=
    cpu_to_le16(BNXT_COAL_CMPL_AGGR_TMR_DURING_INT_ENABLE);
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-12-27 18:53    [W:4.195 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site