lkml.org 
[lkml]   [2019]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 3/4] Bluetooth: hci_qca: Enable power off/on support during hci down/up for QCA Rome
From
Date
Hi Rocky,

> This patch registers hdev->shutdown() callback and also sets
> HCI_QUIRK_NON_PERSISTENT_SETUP for QCA Rome. It will power-off the BT chip
> during hci down and power-on/initialize the chip again during hci up.
>
> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
> ---
>
> Changes in v2: None
>
> drivers/bluetooth/hci_qca.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 45042aa27fa4..7e202041ed77 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1300,6 +1300,11 @@ static int qca_setup(struct hci_uart *hu)
> } else {
> bt_dev_info(hdev, "ROME setup");
> if (hu->serdev) {
> + /* Enable NON_PERSISTENT_SETUP QUIRK to ensure to
> + * execute setup for every hci up.
> + */
> + set_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks);
> + hu->hdev->shutdown = qca_power_off;

why are you setting it in the ->setup callback and not in the ->probe callback?

Regards

Marcel

\
 
 \ /
  Last update: 2019-12-26 21:31    [W:0.086 / U:3.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site