Messages in this thread | | | Date | Wed, 25 Dec 2019 18:01:42 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 4/5] spi: uniphier: Add SPI_LOOP to the capabilities |
| |
On Tue, Dec 24, 2019 at 09:58:26AM +0900, Kunihiko Hayashi wrote: > Add SPI_LOOP to the capabilities to support loopback mode.
> master->min_speed_hz = DIV_ROUND_UP(clk_rate, SSI_MAX_CLK_DIVIDER); > - master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LSB_FIRST; > + master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LSB_FIRST | > + SPI_LOOP;
I'd expect to see a matching change that configures the hardware in loopback mode when the driver is in SPI_MODE? There's nothing in the existing driver. [unhandled content-type:application/pgp-signature] | |