Messages in this thread | | | Subject | Re: [PATCH net-next v8 14/14] ethtool: provide link state with LINKSTATE_GET request | From | Florian Fainelli <> | Date | Mon, 23 Dec 2019 20:44:19 -0800 |
| |
On 12/22/2019 3:46 PM, Michal Kubecek wrote: > Implement LINKSTATE_GET netlink request to get link state information. > > At the moment, only link up flag as provided by ETHTOOL_GLINK ioctl command > is returned. > > LINKSTATE_GET request can be used with NLM_F_DUMP (without device > identification) to request the information for all devices in current > network namespace providing the data. > > Signed-off-by: Michal Kubecek <mkubecek@suse.cz> > ---
[snip]
> +Kernel response contents: > + > + ==================================== ====== ========================== > + ``ETHTOOL_A_LINKSTATE_HEADER`` nested reply header > + ``ETHTOOL_A_LINKSTATE_LINK`` u8 autonegotiation status
^ ==== Humm, auto-negotiation status may not be exactly accurate especially with complex devices with SerDes/PHY/SFPs/what have you/. Other than that, the code looks correct:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |