Messages in this thread | | | From | Khem Raj <> | Date | Mon, 23 Dec 2019 14:25:02 -0800 | Subject | Re: [PATCH] x86/boot/compressed/64: Define __force_order only when CONFIG_RANDOMIZE_BASE is unset |
| |
On Mon, Dec 23, 2019 at 9:10 AM Kirill A. Shutemov <kirill@shutemov.name> wrote: > > On Sat, Dec 21, 2019 at 07:18:13AM -0800, Khem Raj wrote: > > Since arch/x86/boot/compressed/Makefile overrides global CFLAGS it loses > > -fno-common option which would have caught this > > If this doesn't cause any visible problems, why bother? >
it does break builds with gcc trunk as of now e.g.
> Hopefully, we will be able to drop it altogether once we ditch GCC 4.X > support. >
gcc10 is switching defaults to -fno-common so we need to solve this one way or other, I am not sure if gcc 4.x will be dropped before gcc10 release which would be in mid of 2020
> -- > Kirill A. Shutemov
| |