Messages in this thread Patch in this message |  | | Date | Mon, 23 Dec 2019 21:35:14 -0000 | | From | "tip-bot2 for Hewenliang" <> | | Subject | [tip: perf/urgent] tools lib traceevent: Fix memory leakage in filter_event |
| |
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: f84ae29a6169318f9c929720c49d96323d2bbab9 Gitweb: https://git.kernel.org/tip/f84ae29a6169318f9c929720c49d96323d2bbab9 Author: Hewenliang <hewenliang4@huawei.com> AuthorDate: Mon, 09 Dec 2019 01:35:49 -05:00 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitterDate: Fri, 20 Dec 2019 18:47:50 -03:00
tools lib traceevent: Fix memory leakage in filter_event
It is necessary to call free_arg(arg) when add_filter_type() returns NULL in filter_event().
Signed-off-by: Hewenliang <hewenliang4@huawei.com> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org> Cc: Feilong Lin <linfeilong@huawei.com> Cc: Tzvetomir Stoyanov <tstoyanov@vmware.com> Link: http://lore.kernel.org/lkml/20191209063549.59941-1-hewenliang4@huawei.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/lib/traceevent/parse-filter.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c index f3cbf86..20eed71 100644 --- a/tools/lib/traceevent/parse-filter.c +++ b/tools/lib/traceevent/parse-filter.c @@ -1228,8 +1228,10 @@ filter_event(struct tep_event_filter *filter, struct tep_event *event, } filter_type = add_filter_type(filter, event->id); - if (filter_type == NULL) + if (filter_type == NULL) { + free_arg(arg); return TEP_ERRNO__MEM_ALLOC_FAILED; + } if (filter_type->filter) free_arg(filter_type->filter);
|  |