lkml.org 
[lkml]   [2019]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH bpf] libbpf: Fix build on read-only filesystems
Hello,

On Mon, Dec 23, 2019 at 2:55 PM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Sun, Dec 22, 2019 at 9:45 PM Andrii Nakryiko
> <andrii.nakryiko@gmail.com> wrote:
> >
> > On Sun, Dec 22, 2019 at 7:05 PM Namhyung Kim <namhyung@kernel.org> wrote:
> > >
> > > I got the following error when I tried to build perf on a read-only
> > > filesystem with O=dir option.
> > >
> > > $ cd /some/where/ro/linux/tools/perf
> > > $ make O=$HOME/build/perf
> > > ...
> > > CC /home/namhyung/build/perf/lib.o
> > > /bin/sh: bpf_helper_defs.h: Read-only file system
> > > make[3]: *** [Makefile:184: bpf_helper_defs.h] Error 1
> > > make[2]: *** [Makefile.perf:778: /home/namhyung/build/perf/libbpf.a] Error 2
> > > make[2]: *** Waiting for unfinished jobs....
> > > LD /home/namhyung/build/perf/libperf-in.o
> > > AR /home/namhyung/build/perf/libperf.a
> > > PERF_VERSION = 5.4.0
> > > make[1]: *** [Makefile.perf:225: sub-make] Error 2
> > > make: *** [Makefile:70: all] Error 2
> > >
> > > It was becaused bpf_helper_defs.h was generated in current directory.
> > > Move it to OUTPUT directory.
> > >
> > > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > > ---
> >
> > Looks good, thanks!
>
> just one minor thing: bpf_helper_defs.h has to be added to .gitignore
> under selftests/bpf now
>
> >
> > Tested-by: Andrii Nakryiko <andriin@fb.com>
> > Acked-by: Andrii Nakryiko <andriin@fb.com>

Thanks a lot for the review, I'll send v3 soon

Thanks
Namhyung

\
 
 \ /
  Last update: 2019-12-23 07:10    [W:0.035 / U:2.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site