lkml.org 
[lkml]   [2019]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH RESEND v2 02/17] KVM: X86: Change parameter for fast_page_fault tracepoint
    Date
    It would be clearer to dump the return value to know easily on whether
    did we go through the fast path for handling current page fault.
    Remove the old two last parameters because after all the old/new sptes
    were dumped in the same line.

    Signed-off-by: Peter Xu <peterx@redhat.com>
    ---
    arch/x86/kvm/mmutrace.h | 9 ++-------
    1 file changed, 2 insertions(+), 7 deletions(-)

    diff --git a/arch/x86/kvm/mmutrace.h b/arch/x86/kvm/mmutrace.h
    index 7ca8831c7d1a..09bdc5c91650 100644
    --- a/arch/x86/kvm/mmutrace.h
    +++ b/arch/x86/kvm/mmutrace.h
    @@ -244,9 +244,6 @@ TRACE_EVENT(
    __entry->access)
    );

    -#define __spte_satisfied(__spte) \
    - (__entry->retry && is_writable_pte(__entry->__spte))
    -
    TRACE_EVENT(
    fast_page_fault,
    TP_PROTO(struct kvm_vcpu *vcpu, gva_t gva, u32 error_code,
    @@ -274,12 +271,10 @@ TRACE_EVENT(
    ),

    TP_printk("vcpu %d gva %lx error_code %s sptep %p old %#llx"
    - " new %llx spurious %d fixed %d", __entry->vcpu_id,
    + " new %llx ret %d", __entry->vcpu_id,
    __entry->gva, __print_flags(__entry->error_code, "|",
    kvm_mmu_trace_pferr_flags), __entry->sptep,
    - __entry->old_spte, __entry->new_spte,
    - __spte_satisfied(old_spte), __spte_satisfied(new_spte)
    - )
    + __entry->old_spte, __entry->new_spte, __entry->retry)
    );

    TRACE_EVENT(
    --
    2.24.1
    \
     
     \ /
      Last update: 2019-12-21 02:51    [W:4.106 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site