lkml.org 
[lkml]   [2019]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 16/34] scsi: qla2xxx: Don't call qlt_async_event twice
    Date
    From: Roman Bolshakov <r.bolshakov@yadro.com>

    [ Upstream commit 2c2f4bed9b6299e6430a65a29b5d27b8763fdf25 ]

    MBA_PORT_UPDATE generates duplicate log lines in target mode because
    qlt_async_event is called twice. Drop the calls within the case as the
    function will be called right after the switch statement.

    Cc: Quinn Tran <qutran@marvell.com>
    Link: https://lore.kernel.org/r/20191125165702.1013-8-r.bolshakov@yadro.com
    Acked-by: Himanshu Madhani <hmadhani@marvel.com>
    Reviewed-by: Hannes Reinecke <hare@suse.de>
    Tested-by: Hannes Reinecke <hare@suse.de>
    Acked-by: Himanshu Madhani <hmadhani@marvell.com>
    Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/qla2xxx/qla_isr.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
    index afe15b3e45fbf..e6d162945f5db 100644
    --- a/drivers/scsi/qla2xxx/qla_isr.c
    +++ b/drivers/scsi/qla2xxx/qla_isr.c
    @@ -1049,8 +1049,6 @@ qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb)
    ql_dbg(ql_dbg_async, vha, 0x5011,
    "Asynchronous PORT UPDATE ignored %04x/%04x/%04x.\n",
    mb[1], mb[2], mb[3]);
    -
    - qlt_async_event(mb[0], vha, mb);
    break;
    }

    @@ -1067,8 +1065,6 @@ qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb)
    set_bit(LOOP_RESYNC_NEEDED, &vha->dpc_flags);
    set_bit(LOCAL_LOOP_UPDATE, &vha->dpc_flags);
    set_bit(VP_CONFIG_OK, &vha->vp_flags);
    -
    - qlt_async_event(mb[0], vha, mb);
    break;

    case MBA_RSCN_UPDATE: /* State Change Registration */
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-12-20 15:35    [W:4.149 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site