Messages in this thread |  | | Subject | Re: [PATCH] x86/resctrl: Fix potential memory leak | | From | Reinette Chatre <> | | Date | Thu, 19 Dec 2019 21:46:40 -0800 |
| |
Hi Shakeel,
On 12/19/2019 5:54 PM, Shakeel Butt wrote: > On Thu, Dec 19, 2019 at 3:27 PM Reinette Chatre > <reinette.chatre@intel.com> wrote: >> On 12/19/2019 2:38 PM, Shakeel Butt wrote: >>> The set_cache_qos_cfg() is leaking memory when the given level is not >>> RDT_RESOURCE_L3 or RDT_RESOURCE_L2. Fix that. >> >> I think it would be valuable to those considering whether they need to >> backport to know that RDT_RESOURCE_L3 and RDT_RESOURCE_L2 are currently >> the only possible levels with which this function is called. It is thus >> not currently possible for this leak to occur. Indeed a valuable safety >> to add in case this code may change in the future. Thank you very much. >> > > Do you want me to add that info the commit and resend the v2 of the patch? >
Yes please.
Thank you very much
Reinette
|  |