Messages in this thread | | | Subject | Re: [PATCH] platform/chrome: cros-ec: make init_lock static | From | Enric Balletbo i Serra <> | Date | Fri, 20 Dec 2019 10:04:50 +0100 |
| |
Hi Ben,
Thanks for the patch.
On 18/12/19 11:07, Ben Dooks (Codethink) wrote: > The init_lock is not declared or used outside of cros_ec_ishtp.c > so make it static to avoid the following warning: > > drivers/platform/chrome/cros_ec_ishtp.c:79:1: warning: symbol 'init_lock' was not declared. Should it be static? > > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
Applied for 5.6
> --- > Cc: Benson Leung <bleung@chromium.org> > Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Cc: Guenter Roeck <groeck@chromium.org> > Cc: linux-kernel@vger.kernel.org > --- > drivers/platform/chrome/cros_ec_ishtp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/chrome/cros_ec_ishtp.c b/drivers/platform/chrome/cros_ec_ishtp.c > index e5996821d08b..5f8e76f3022a 100644 > --- a/drivers/platform/chrome/cros_ec_ishtp.c > +++ b/drivers/platform/chrome/cros_ec_ishtp.c > @@ -76,7 +76,7 @@ struct cros_ish_in_msg { > * > * The writers are .reset() and .probe() function. > */ > -DECLARE_RWSEM(init_lock); > +static DECLARE_RWSEM(init_lock); > > /** > * struct response_info - Encapsulate firmware response related >
| |