| Date | Fri, 20 Dec 2019 14:02:16 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH v7 04/12] dmaengine: Add metadata_ops for dma_async_tx_descriptor |
| |
Hi Peter,
On 09-12-19, 11:43, Peter Ujfalusi wrote:
> +int dmaengine_desc_attach_metadata(struct dma_async_tx_descriptor *desc, > + void *data, size_t len) > +{ > + int ret; > + > + if (!desc) > + return -EINVAL; > + > + ret = desc_check_and_set_metadata_mode(desc, DESC_METADATA_CLIENT); > + if (ret) > + return ret; > + > + if (!desc->metadata_ops || !desc->metadata_ops->attach) > + return -ENOTSUPP; > + > + return desc->metadata_ops->attach(desc, data, len);
this looks good to me, only thing is we should check if people are mixing the modes :)
-- ~Vinod
|