Messages in this thread | | | Date | Mon, 2 Dec 2019 15:42:44 -0800 | From | Fenghua Yu <> | Subject | Re: [PATCH v8 01/13] selftests/resctrl: Add README for resctrl tests |
| |
On Tue, Dec 03, 2019 at 12:06:42AM +0100, Borislav Petkov wrote: > On Mon, Dec 02, 2019 at 10:53:35AM -0800, Fenghua Yu wrote: > > Babu's major contributions are in v5 where he virtually touched every > > patch. He sent out v5 and put Signed-off-by: Babu Moger in each patch: > > https://lore.kernel.org/patchwork/cover/1033532/ > > > > That's why I keep his SOB in v6-v8 in each patch. > > For that you either need to use > > Co-developed-by: Babu > > or state the fact that Babu did contribute to the patches in freetext in > the commit messages. > > As it is now, it is not clear what it means. You could've kept the order > from v5 since you took his submission and could've done: > > Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> > Signed-off-by: Babu Moger <babu.moger@amd.com> > Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> > > to show you're the author, Babu handled them further and you're sending > the patchset now, but the other thing I suggested above is more clear > IMO.
Ok. I will add Co-developed-by: Babu in the patches.
Should I send v9 patch set with only the Co-developed-by changes?
Thanks.
-Fenghua
| |