lkml.org 
[lkml]   [2019]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/7] arm64: dts: realtek: rtd129x: Use reserved-memory for RPC regions
Date
Hi Andreas,

> > /memreserve/ 0x0000000000000000 0x0000000000030000;
> > -/memreserve/ 0x000000000001f000 0x0000000000001000;
> > /memreserve/ 0x0000000000030000 0x00000000000d0000;
> > /memreserve/ 0x0000000001b00000 0x00000000004be000;
> > -/memreserve/ 0x0000000001ffe000 0x0000000000004000;
> >

> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > #include <dt-bindings/reset/realtek,rtd1295.h>
> > @@ -19,6 +17,25 @@
> > #address-cells = <1>;
> > #size-cells = <1>;
> >
> > + reserved-memory {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges;
> > +
> > + rpc_comm: rpc@1f000 {
> > + reg = <0x1f000 0x1000>;
> > + };
> > +
> > + rpc_ringbuf: rpc@1ffe000 {
> > + reg = <0x1ffe000 0x4000>;
> > + };
>
> Have you reviewed this patch to be correct? I.e., are the above two regions
> reserved RAM (assumption above), or is this rather MMIO shadowing RAM?
> (then we would need to update the /memory reg and /soc ranges properties)
>
> That also affects RTD1619, which currently has neither.
>
The RPC common buffer and RPC ring buffer address is correct.


Regards,
James


\
 
 \ /
  Last update: 2019-12-02 10:55    [W:0.047 / U:9.212 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site