lkml.org 
[lkml]   [2019]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 004/162] x86/PCI: Avoid AMD FCH XHCI USB PME# from D0 defect
    Date
    From: Kai-Heng Feng <kai.heng.feng@canonical.com>

    commit 7e8ce0e2b036dbc6617184317983aea4f2c52099 upstream.

    The AMD FCH USB XHCI Controller advertises support for generating PME#
    while in D0. When in D0, it does signal PME# for USB 3.0 connect events,
    but not for USB 2.0 or USB 1.1 connect events, which means the controller
    doesn't wake correctly for those events.

    00:10.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] FCH USB XHCI Controller [1022:7914] (rev 20) (prog-if 30 [XHCI])
    Subsystem: Dell FCH USB XHCI Controller [1028:087e]
    Capabilities: [50] Power Management version 3
    Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)

    Clear PCI_PM_CAP_PME_D0 in dev->pme_support to indicate the device will not
    assert PME# from D0 so we don't rely on it.

    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=203673
    Link: https://lore.kernel.org/r/20190902145252.32111-1-kai.heng.feng@canonical.com
    Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
    Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/x86/pci/fixup.c | 11 +++++++++++
    1 file changed, 11 insertions(+)

    --- a/arch/x86/pci/fixup.c
    +++ b/arch/x86/pci/fixup.c
    @@ -542,6 +542,17 @@ static void twinhead_reserve_killing_zon
    DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x27B9, twinhead_reserve_killing_zone);

    /*
    + * Device [1022:7914]
    + * When in D0, PME# doesn't get asserted when plugging USB 2.0 device.
    + */
    +static void pci_fixup_amd_fch_xhci_pme(struct pci_dev *dev)
    +{
    + dev_info(&dev->dev, "PME# does not work under D0, disabling it\n");
    + dev->pme_support &= ~(PCI_PM_CAP_PME_D0 >> PCI_PM_CAP_PME_SHIFT);
    +}
    +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, 0x7914, pci_fixup_amd_fch_xhci_pme);
    +
    +/*
    * Broadwell EP Home Agent BARs erroneously return non-zero values when read.
    *
    * See http://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html

    \
     
     \ /
      Last update: 2022-09-17 16:07    [W:3.614 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site