Messages in this thread |  | | Date | Thu, 19 Dec 2019 20:56:31 -0500 | | From | Steven Rostedt <> | | Subject | Re: [PATCH] tools lib traceevent: Fix memory leakage in filter_event |
| |
On Mon, 9 Dec 2019 01:35:49 -0500 Hewenliang <hewenliang4@huawei.com> wrote:
> It is necessary to call free_arg(arg) when add_filter_type returns NULL in > the function of filter_event. > > Signed-off-by: Hewenliang <hewenliang4@huawei.com>
This looks fine.
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Arnaldo, care to take this?
-- Steve
> --- > tools/lib/traceevent/parse-filter.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c > index f3cbf86e51ac..20eed719542e 100644 > --- a/tools/lib/traceevent/parse-filter.c > +++ b/tools/lib/traceevent/parse-filter.c > @@ -1228,8 +1228,10 @@ filter_event(struct tep_event_filter *filter, struct tep_event *event, > } > > filter_type = add_filter_type(filter, event->id); > - if (filter_type == NULL) > + if (filter_type == NULL) { > + free_arg(arg); > return TEP_ERRNO__MEM_ALLOC_FAILED; > + } > > if (filter_type->filter) > free_arg(filter_type->filter);
|  |