Messages in this thread Patch in this message |  | | Date | Thu, 19 Dec 2019 21:00:16 +0100 | | From | Cornelia Huck <> | | Subject | Re: [PATCH] vfio/mdev: make create attribute static |
| |
On Wed, 18 Dec 2019 12:31:19 +0000 "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk> wrote:
> The create attribute is not exported, so make it > static to avoid the following sparse warning: > > drivers/vfio/mdev/mdev_sysfs.c:77:1: warning: symbol 'mdev_type_attr_create' was not declared. Should it be static? > > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> > --- > Cc: Kirti Wankhede <kwankhede@nvidia.com> > Cc: Alex Williamson <alex.williamson@redhat.com> > Cc: Cornelia Huck <cohuck@redhat.com> > Cc: kvm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/vfio/mdev/mdev_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c > index 7570c7602ab4..8ad14e5c02bf 100644 > --- a/drivers/vfio/mdev/mdev_sysfs.c > +++ b/drivers/vfio/mdev/mdev_sysfs.c > @@ -74,7 +74,7 @@ static ssize_t create_store(struct kobject *kobj, struct device *dev, > return count; > } > > -MDEV_TYPE_ATTR_WO(create); > +static MDEV_TYPE_ATTR_WO(create); > > static void mdev_type_release(struct kobject *kobj) > {
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
|  |