lkml.org 
[lkml]   [2019]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 25/80] rpmsg: glink: Fix rpmsg_register_device err handling
    Date
    From: Chris Lew <clew@codeaurora.org>

    commit f7e714988edaffe6ac578318e99501149b067ba0 upstream.

    The device release function is set before registering with rpmsg. If
    rpmsg registration fails, the framework will call device_put(), which
    invokes the release function. The channel create logic does not need to
    free rpdev if rpmsg_register_device() fails and release is called.

    Fixes: b4f8e52b89f6 ("rpmsg: Introduce Qualcomm RPM glink driver")
    Cc: stable@vger.kernel.org
    Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    Signed-off-by: Chris Lew <clew@codeaurora.org>
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/rpmsg/qcom_glink_native.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    --- a/drivers/rpmsg/qcom_glink_native.c
    +++ b/drivers/rpmsg/qcom_glink_native.c
    @@ -1423,15 +1423,13 @@ static int qcom_glink_rx_open(struct qco

    ret = rpmsg_register_device(rpdev);
    if (ret)
    - goto free_rpdev;
    + goto rcid_remove;

    channel->rpdev = rpdev;
    }

    return 0;

    -free_rpdev:
    - kfree(rpdev);
    rcid_remove:
    spin_lock_irqsave(&glink->idr_lock, flags);
    idr_remove(&glink->rcids, channel->rcid);

    \
     
     \ /
      Last update: 2019-12-19 19:59    [W:4.540 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site