Messages in this thread Patch in this message | | | From | Aditya Pakki <> | Subject | [PATCH v2] tpm/ppi: remove impossible assertion in tpm_eval_dsm | Date | Wed, 18 Dec 2019 09:48:25 -0600 |
| |
In tpm_eval_dsm, BUG_ON on ppi_handle is used as an assertion. However, if ppi_handle is NULL, the kernel crashes. The patch removes the unnecessary check.
Signed-off-by: Aditya Pakki <pakki001@umn.edu> --- v1: replaced the recovery code to completely eliminate the check, as suggested by Jason Gunthorpe. --- drivers/char/tpm/tpm_ppi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/char/tpm/tpm_ppi.c b/drivers/char/tpm/tpm_ppi.c index b2dab941cb7f..603f7806f9af 100644 --- a/drivers/char/tpm/tpm_ppi.c +++ b/drivers/char/tpm/tpm_ppi.c @@ -42,7 +42,6 @@ static inline union acpi_object * tpm_eval_dsm(acpi_handle ppi_handle, int func, acpi_object_type type, union acpi_object *argv4, u64 rev) { - BUG_ON(!ppi_handle); return acpi_evaluate_dsm_typed(ppi_handle, &tpm_ppi_guid, rev, func, argv4, type); } -- 2.20.1
| |