Messages in this thread | | | Subject | Re: [PATCH] scsi: libfc: remove unnecessary assertion on ep variable | From | Hannes Reinecke <> | Date | Wed, 18 Dec 2019 12:12:52 +0100 |
| |
On 12/17/19 10:22 PM, Aditya Pakki wrote: > In ft_recv_write_data(), the pointer ep is dereferenced first and > then asserts for NULL. The patch removes the unnecessary assertion. > > Signed-off-by: Aditya Pakki <pakki001@umn.edu> > --- > drivers/target/tcm_fc/tfc_io.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c > index 1354a157e9af..6a38ff936389 100644 > --- a/drivers/target/tcm_fc/tfc_io.c > +++ b/drivers/target/tcm_fc/tfc_io.c > @@ -221,7 +221,6 @@ void ft_recv_write_data(struct ft_cmd *cmd, struct fc_frame *fp) > ep = fc_seq_exch(seq); > lport = ep->lp; > if (cmd->was_ddp_setup) { > - BUG_ON(!ep); > BUG_ON(!lport); > /* > * Since DDP (Large Rx offload) was setup for this request, > Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
| |