lkml.org 
[lkml]   [2019]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next 2/3] ptp: clockmatrix: Remove IDT references or replace with Renesas.
From
From: vincent.cheng.xh@renesas.com
Date: Tue, 17 Dec 2019 00:03:07 -0500

> From: Vincent Cheng <vincent.cheng.xh@renesas.com>
>
> Renesas Electronics Corporation completed acquisition of IDT in 2019.
>
> This patch removes IDT references or replaces IDT with Renesas.
> Renamed idt8a340_reg.h to clockmatrix_reg.h.
> There were no functional changes.
>
> Signed-off-by: Vincent Cheng <vincent.cheng.xh@renesas.com>

Sorry, we don't do stuff like this.

The driver shall keep the reference to it's old vendor name, and
this is how we've handled similar situations in the past.

And do you know the worst part about this? You DID in fact
functionally change this driver:

> -#define FW_FILENAME "idtcm.bin"
> +#define FW_FILENAME "cm_tcs.bin"

Now everyone would have missing firmware.

So not only is this unacceptable on precedence grounds, and how we
always handle situations like this, it's functionally wrong and would
break things for users.

Please remove this patch and resubmit #1 and #3 as a series for
re-review.

Thank you.

\
 
 \ /
  Last update: 2019-12-18 07:31    [W:0.187 / U:4.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site