Messages in this thread | | | Subject | Re: [PATCH RFC 1/3] block: Add support for REQ_OP_ASSIGN_RANGE operation | From | "Martin K. Petersen" <> | Date | Wed, 18 Dec 2019 22:03:34 -0500 |
| |
Hi Kirill!
> The patch adds a new blkdev_issue_assign_range() primitive, which is > rather similar to existing blkdev_issue_{*} api. Also, a new queue > limit.max_assign_range_sectors is added.
I am not so keen on the assign_range name. What's wrong with "allocate"?
But why introduce a completely new operation? Isn't this essentially a write zeroes with BLKDEV_ZERO_NOUNMAP flag set?
If the zeroing aspect is perceived to be a problem we could add a BLKDEV_ZERO_ALLOCATE flag (or BLKDEV_ZERO_ANCHOR since that's the terminology used in SCSI).
-- Martin K. Petersen Oracle Linux Engineering
| |