lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v9 00/13] selftests/resctrl: Add resctrl selftest
From
Date
Fenghua,
Thanks for the patches. I did a quick test. I am seeing some failures with
this series. I need to debug to figure out what is going on. Hopefully I
will be able to spend sometime this week or next week. I will be out for
few days this week and also next week. Here is the failure..

# ./resctrl_tests -t cat
TAP version 13
ok kernel supports resctrl filesystem
ok resctrl mountpoint "/sys/fs/resctrl" exists
# resctrl filesystem is mounted
# dmesg: [ 6.558645] resctrl: L3 allocation detected
# dmesg: [ 6.558646] resctrl: L3DATA allocation detected
# dmesg: [ 6.558646] resctrl: L3CODE allocation detected
# dmesg: [ 6.558647] resctrl: MB allocation detected
# dmesg: [ 6.558647] resctrl: L3 monitoring detected
# Starting CAT test ...
ok mounting resctrl to "/sys/fs/resctrl"
cache size :16777216
ok writing benchmark parameters to resctrl FS
ok writing benchmark parameters to resctrl FS
ok Write schema "L3:0=7ff" to resctrl FS
ok Write schema "L3:15=f800" to resctrl FS
Error opening leader: No such file or directory
Killed


On 12/16/19 4:26 PM, Fenghua Yu wrote:
> With more and more resctrl features are being added by Intel, AMD
> and ARM, a test tool is becoming more and more useful to validate
> that both hardware and software functionalities work as expected.
>
> We introduce resctrl selftest to cover resctrl features on X86, AMD
> and ARM architectures. It first implements MBM (Memory Bandwidth
> Monitoring), MBA (Memory Bandwidth Allocation), L3 CAT (Cache Allocation
> Technology), and CQM (Cache QoS Monitoring) tests. We will enhance
> the selftest tool to include more functionality tests in the future.
>
> The tool has been tested on Intel RDT, AMD QoS and ARM MPAM and is
> in tools/testing/selftests/resctrl in order to have generic test code
> base for all architectures.
>
> The selftest tool we are introducing here provides a convenient
> tool which does automatic resctrl testing, is easily available in kernel
> tree, and covers Intel RDT, AMD QoS and ARM MPAM.
>
> There is an existing resctrl test suite 'intel_cmt_cat'. But its major
> purpose is to test Intel RDT hardware via writing and reading MSR
> registers. It does access resctrl file system; but the functionalities
> are very limited. And it doesn't support automatic test and a lot of
> manual verifications are involved.
>
> Changelog:
> v9:
> - Per Boris suggestion, add Co-developed-by in each patch to make it
> clear who contributed to the patch set.
>
> v8:
> Update code per comments from Andre Przywara from ARM:
> - Change Makefile and remove inline assembly code to build and test the
> tool on ARM
> - Change the output to TAP format because the format is both readable by
> human and other test tools.
> - Detect resctrl feature from /proc/cpuinfo instead of dmesg to support
> generic detection on all architectures.
> - Fix a few coding issues.
>
> v7:
> - Fix a few warnings when compiling patches separately, pointed by Babu
>
> v6:
> - Fix a benchmark reading optimized out issue in newer GCC.
> - Fix a few coding style issues.
> - Re-arrange code among patches to make cleaner code. No change in patches
> structure.
>
> v5:
> - Based the v4 patches submitted by Fenghua Yu and added changes to support
> AMD.
> - Changed the function name get_sock_num to get_resource_id. Intel uses
> socket number for schemata and AMD uses l3 index id. To generalize,
> changed the function name to get_resource_id.
> - Added the code to detect vendor.
> - Disabled the few tests for AMD where the test results are not clear.
> Also AMD does not have IMC.
> - Fixed few compile issues.
> - Some cleanup to make each patch independent.
> - Tested the patches on AMD system. Fenghua, Need your help to test on
> Intel box. Please feel free to change and resubmit if something
> broken.
>
> v4:
> - address comments from Balu and Randy
> - Add CAT and CQM tests
>
> v3:
> - Change code based on comments from Babu Moger
> - Remove some unnessary code and use pipe to communicate b/w processes
>
> v2:
> - Change code based on comments from Babu Moger
> - Clean up other places.
>
> Babu Moger (3):
> selftests/resctrl: Add vendor detection mechanism
> selftests/resctrl: Use cache index3 id for AMD schemata masks
> selftests/resctrl: Disable MBA and MBM tests for AMD
>
> Fenghua Yu (6):
> selftests/resctrl: Add README for resctrl tests
> selftests/resctrl: Add MBM test
> selftests/resctrl: Add MBA test
> selftests/resctrl: Add Cache QoS Monitoring (CQM) selftest
> selftests/resctrl: Add Cache Allocation Technology (CAT) selftest
> selftests/resctrl: Add the test in MAINTAINERS
>
> Sai Praneeth Prakhya (4):
> selftests/resctrl: Add basic resctrl file system operations and data
> selftests/resctrl: Read memory bandwidth from perf IMC counter and
> from resctrl file system
> selftests/resctrl: Add callback to start a benchmark
> selftests/resctrl: Add built in benchmark
>
> MAINTAINERS | 1 +
> tools/testing/selftests/resctrl/Makefile | 17 +
> tools/testing/selftests/resctrl/README | 53 ++
> tools/testing/selftests/resctrl/cache.c | 272 +++++++
> tools/testing/selftests/resctrl/cat_test.c | 250 ++++++
> tools/testing/selftests/resctrl/cqm_test.c | 176 +++++
> tools/testing/selftests/resctrl/fill_buf.c | 213 +++++
> tools/testing/selftests/resctrl/mba_test.c | 171 ++++
> tools/testing/selftests/resctrl/mbm_test.c | 145 ++++
> tools/testing/selftests/resctrl/resctrl.h | 107 +++
> .../testing/selftests/resctrl/resctrl_tests.c | 202 +++++
> tools/testing/selftests/resctrl/resctrl_val.c | 744 ++++++++++++++++++
> tools/testing/selftests/resctrl/resctrlfs.c | 722 +++++++++++++++++
> 13 files changed, 3073 insertions(+)
> create mode 100644 tools/testing/selftests/resctrl/Makefile
> create mode 100644 tools/testing/selftests/resctrl/README
> create mode 100644 tools/testing/selftests/resctrl/cache.c
> create mode 100644 tools/testing/selftests/resctrl/cat_test.c
> create mode 100644 tools/testing/selftests/resctrl/cqm_test.c
> create mode 100644 tools/testing/selftests/resctrl/fill_buf.c
> create mode 100644 tools/testing/selftests/resctrl/mba_test.c
> create mode 100644 tools/testing/selftests/resctrl/mbm_test.c
> create mode 100644 tools/testing/selftests/resctrl/resctrl.h
> create mode 100644 tools/testing/selftests/resctrl/resctrl_tests.c
> create mode 100644 tools/testing/selftests/resctrl/resctrl_val.c
> create mode 100644 tools/testing/selftests/resctrl/resctrlfs.c
>

\
 
 \ /
  Last update: 2019-12-17 19:26    [W:0.070 / U:10.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site