Messages in this thread | | | Date | Tue, 17 Dec 2019 10:21:54 -0800 | From | Matthias Kaehlcke <> | Subject | Re: [PATCH] arm64: dts: sc7180: Enable video node |
| |
Hi
On Tue, Dec 17, 2019 at 01:23:38PM +0530, Dikshita Agarwal wrote: > This is a preparation gerrit to enable video node for sc7180.
gerrit is a code review tool, please change to something like "Add venus video codec node for sc7180"
> This change depends on patch series Venus new features.
Notes like this should not be part of the commit message, but put below '---'. It would also be good to include a link to the series, I suppose it's https://patchwork.kernel.org/project/linux-arm-msm/list/?series=213439
> Signed-off-by: Dikshita Agarwal <dikshita@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 52a5861..ccf9ef5 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -1297,6 +1297,34 @@ > > #freq-domain-cells = <1>; > }; > + > + venus: video-codec@aa00000 { > + compatible = "qcom,sc7180-venus";
This compatible string is not listed in the bindings (Documentation/devicetree/bindings/media/qcom,venus.txt), nor in the driver.
| |