Messages in this thread | | | From | Olof Johansson <> | Date | Tue, 17 Dec 2019 10:01:15 -0800 | Subject | Re: [PATCH v3] clk: declare clk_core_reparent_orphans() inline |
| |
On Tue, Dec 17, 2019 at 12:25 AM Stephen Boyd <sboyd@kernel.org> wrote: > > Quoting Olof Johansson (2019-12-16 20:46:35) > > A recent addition exposed a helper that is only used for > > CONFIG_OF. Instead of figuring out best place to have it in the order > > of various functions, just declare it as explicitly inline, and the > > compiler will happily handle it without warning. > > > > (Also fixup of a single stray empty line while I was looking at the code) > > > > Fixes: 66d9506440bb ("clk: walk orphan list on clock provider registration") > > Signed-off-by: Olof Johansson <olof@lixom.net> > > --- > > > > v3: ACTUALLY amend this time. Sigh. Time to go home. > > > > Isn't it simple enough to just move the function down to CONFIG_OF in > drivers/clk/clk.c?
"Simple" in a 5000 line file is maybe not the right word to use, but yeah, sure, do with it what you want.
Seems like clk.c could do with some refactoring? :)
-Olof
| |