Messages in this thread | | | Subject | Re: [PATCH] tty: serial: samsung_tty: do not abuse the struct uart_port unused fields | From | Dmitry Safonov <> | Date | Tue, 17 Dec 2019 15:47:34 +0000 |
| |
On 12/17/19 2:02 PM, Greg Kroah-Hartman wrote: > The samsung_tty driver was trying to abuse the struct uart_port by using > two "empty" bytes for its own use. That's not ok, and was found by > removing those fields from the structure. > > Move the variables into the port-specific structure, which is where > everything else for this port already is. There is no space wasted here > as there was an empty "hole" in the structure already for these bytes.
Thanks! Sorry for not noticing this myself.
> Cc: Kukjin Kim <kgene@kernel.org> > Cc: Hyunki Koo <kkoos00@naver.com> > Cc: HYUN-KI KOO <hyunki00.koo@samsung.com> > Cc: Shinbeom Choi <sbeom.choi@samsung.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Dmitry Safonov <dima@arista.com> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: linux-serial@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
I see you already applied it to your tree, but in case it helps anything: Reviewed-by: Dmitry Safonov <dima@arista.com>
Thanks, Dmitry
| |