Messages in this thread | | | Date | Tue, 17 Dec 2019 16:56:32 +0200 | From | Mika Westerberg <> | Subject | Re: [PATCH v2 3/9] thunderbolt: Populate PG field in hot plug acknowledgment packet |
| |
On Tue, Dec 17, 2019 at 01:47:45PM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 17, 2019 at 03:33:39PM +0300, Mika Westerberg wrote: > > USB4 1.0 section 6.4.2.7 specifies a new field (PG) in notification > > packet that is sent as response of hot plug/unplug events. This field > > tells whether the acknowledgment is for plug or unplug event. This needs > > to be set accordingly in order the router to send further hot plug > > notifications. > > > > To make it simpler we fill the field unconditionally. Legacy devices do > > not look at this field so there should be no problems with them. > > > > While there rename tb_cfg_error() to tb_cfg_ack_plug() and update the > > log message accordingly. The function is only used to ack plug/unplug > > events. > > > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > First 3 patches look "trivial" enough for me to take right now, any > objection to that?
No objections from my side :)
> Should I be using my usb tree for this?
Yes, I think it makes sense now that this is also under USB IF umbrella.
| |