Messages in this thread | | | Subject | Re: [PATCH] x86/process: remove unused variable in __switch_to_xtra() | From | Yunfeng Ye <> | Date | Tue, 17 Dec 2019 20:30:58 +0800 |
| |
On 2019/12/17 20:29, Borislav Petkov wrote: > On Tue, Dec 17, 2019 at 08:09:08PM +0800, Yunfeng Ye wrote: >> After the commit ecc7e37d4dad ("x86/io: Speedup schedule out of I/O >> bitmap user") and commit 22fe5b0439dd ("x86/ioperm: Move TSS bitmap >> update to exit to user work"), warning is found: >> >> arch/x86/kernel/process.c: In function ‘__switch_to_xtra’: >> arch/x86/kernel/process.c:618:31: warning: variable ‘next’ set but not >> used [-Wunused-but-set-variable] >> struct thread_struct *prev, *next; >> ^~~~ >> arch/x86/kernel/process.c:618:24: warning: variable ‘prev’ set but not >> used [-Wunused-but-set-variable] >> struct thread_struct *prev, *next; >> ^~~~ >> Fix this by removing the unused variable @prev and @next; >> >> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com> >> --- >> arch/x86/kernel/process.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c >> index 61e93a318983..839b5244e3b7 100644 >> --- a/arch/x86/kernel/process.c >> +++ b/arch/x86/kernel/process.c >> @@ -615,12 +615,8 @@ void speculation_ctrl_update_current(void) >> >> void __switch_to_xtra(struct task_struct *prev_p, struct task_struct *next_p) >> { >> - struct thread_struct *prev, *next; >> unsigned long tifp, tifn; >> >> - prev = &prev_p->thread; >> - next = &next_p->thread; >> - >> tifn = READ_ONCE(task_thread_info(next_p)->flags); >> tifp = READ_ONCE(task_thread_info(prev_p)->flags); >> >> -- > > Let me introduce you to your colleague yu kuai: > ok, thanks.
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/cleanups&id=27353d5785bca61bb49cfd7c78e14f1d21e66ec5 > > :-) >
| |