Messages in this thread | | | Date | Tue, 17 Dec 2019 13:58:18 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH] lib: crc64: include <linux/crc64.h> for 'crc64_be' |
| |
On Tue, Dec 17, 2019 at 01:57:03PM +0200, Andy Shevchenko wrote: > On Tue, Dec 17, 2019 at 11:26:33AM +0000, Ben Dooks (Codethink) wrote: > > The crc64_be() is declared in <linux/crc64.h> so include > > this where the symbol is defined to avoid the following > > warning: > > > > lib/crc64.c:43:12: warning: symbol 'crc64_be' was not declared. Should it be static? > > Thanks! > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Sorry, one nit to be addressed...
> > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> > > --- > > Cc: Coly Li <colyli@suse.de> > > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Cc: linux-kernel@vger.kernel.org > > --- > > lib/crc64.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/crc64.c b/lib/crc64.c > > index 0ef8ae6ac047..f8928ce28280 100644 > > --- a/lib/crc64.c > > +++ b/lib/crc64.c > > @@ -28,6 +28,7 @@ > > > > #include <linux/module.h> > > #include <linux/types.h>
> > +#include <linux/crc64.h>
May we preserve ordering, i.e. it should be first header in the block.
> > #include "crc64table.h" > > > > MODULE_DESCRIPTION("CRC64 calculations"); > > -- > > 2.24.0 > > > > -- > With Best Regards, > Andy Shevchenko > >
-- With Best Regards, Andy Shevchenko
| |