Messages in this thread | | | Date | Tue, 17 Dec 2019 11:08:50 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH v2 0/5] iommu: Implement iommu_put_resv_regions_simple() |
| |
Hi Thierry
On Mon, Dec 09, 2019 at 03:50:02PM +0100, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Most IOMMU drivers only need to free the memory allocated for each > reserved region. Instead of open-coding the loop to do this in each > driver, extract the code into a common function that can be used by > all these drivers. > > Changes in v2: > - change subject prefix to "iommu: virtio: " for virtio-iommu.c driver > > Thierry > > Thierry Reding (5): > iommu: Implement iommu_put_resv_regions_simple() > iommu: arm: Use iommu_put_resv_regions_simple() > iommu: amd: Use iommu_put_resv_regions_simple() > iommu: intel: Use iommu_put_resv_regions_simple() > iommu: virtio: Use iommu_put_resv_regions_simple()
Thanks, that is a nice consolidation. Just a minor nit, can you please rename iommu_put_resv_regions_simple to generic_iommu_put_resv_regsions(). That matches the naming in other places where we have done similar things.
Thanks,
Joerg
| |