Messages in this thread | | | Subject | Re: [PATCH v2] hdlcdrv: replace unnecessary assertion in hdlcdrv_register | From | Markus Elfring <> | Date | Tue, 17 Dec 2019 22:27:09 +0100 |
| |
> The three callers of hdlcdrv_register all pass valid pointers and > do not fail. The patch eliminates the unnecessary BUG_ON assertion.
I suggest to replace the wording “The patch eliminates” by “Thus delete” to make it imperative as desired.
Will the tag “Fixes” be added to the final change description?
> --- > drivers/net/hamradio/hdlcdrv.c | 2 --
Please replace these triple dashes by a blank line.
Regards, Markus
| |